1
0
mirror of https://github.com/tcgdex/cards-database.git synced 2025-04-22 10:52:10 +00:00

Update CONTRIBUTING.md (#111)

This commit is contained in:
Florian Bouillon 2021-10-18 12:39:34 +02:00 committed by GitHub
parent 2fc22cc4a5
commit 035a130c6b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -18,15 +18,16 @@ to do this you can check if there is not already an issue/discussion about it, a
To send changes to our repository, you will have to follow the next steps:
- Fork 🍴 the project. _see at the top right of the screen_
- make the changes you want in your Repository.
- Create a Pull request here https://github.com/tcgdex/cards-database/compare
- we don't like ❌, so if your pull request has its automated checks ending with the red cross, please double check your change until it show the awesome 🟢, or ask for help !
- If you pull request is ready for review you can go the 🏖️ and we will handle the rest !
- Fork 🍴 the project. _see the `fork` button at the top right of the screen_
- make the changes you want in your repository.
- Create a Pull request here https://github.com/tcgdex/cards-database/compare by selecting your repository patch with our `master` branch
- we don't like ❌, so if your pull request has its automated checks ending with the red cross, please double check your changes until it show the awesome 🟢, or ask for help !
- If you pull request is ready for review you can go to the 🏖️ and we will handle the rest !
## coding Convention
Install in your dev environment the plugin `.editorconfig` is not already done and thats it !
Install the plugin `.editorconfig` in your dev environment if it's not already done and thats it !
for those who don't want to install it the basic are these:
- Indent using `tab`
- don't uglify your code (_why would you even do it_)