From ba6e5a92eae817e0861a27cbd9fefe1df1cc768b Mon Sep 17 00:00:00 2001 From: LooKeR Date: Fri, 12 Nov 2021 19:34:24 +0530 Subject: [PATCH] Fix: Only Ask for root permission when selected --- .../com/looker/droidify/screen/SettingsFragment.kt | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/main/kotlin/com/looker/droidify/screen/SettingsFragment.kt b/src/main/kotlin/com/looker/droidify/screen/SettingsFragment.kt index 5c94f0de..c82d0446 100644 --- a/src/main/kotlin/com/looker/droidify/screen/SettingsFragment.kt +++ b/src/main/kotlin/com/looker/droidify/screen/SettingsFragment.kt @@ -188,12 +188,9 @@ class SettingsFragment : ScreenFragment() { preferences[Preferences.Key.ProxyHost]?.setEnabled(enabled) preferences[Preferences.Key.ProxyPort]?.setEnabled(enabled) } - if (key != null && !(Shell.getCachedShell()?.isRoot ?: Shell.getShell().isRoot) - ) { - Preferences[Preferences.Key.RootPermission] = false - preferences[Preferences.Key.RootPermission]?.setEnabled(false) - } else if (Shell.getCachedShell()?.isRoot ?: Shell.getShell().isRoot) { - preferences[Preferences.Key.RootPermission]?.setEnabled(true) + if (key == Preferences.Key.RootPermission) { + preferences[Preferences.Key.RootPermission]?.setEnabled(Shell.getCachedShell()?.isRoot + ?: Shell.getShell().isRoot) } if (key == Preferences.Key.Theme) { requireActivity().recreate()