dzeio/components
1
0
Fork 0
mirror of https://github.com/dzeiocom/components.git synced 2025-04-22 10:52:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed button not sending to external link

Browse Source 
Signed-off-by: Avior <florian.bouillon@delta-wings.net>
This commit is contained in:
Florian Bouillon 2021-09-05 14:02:46 +02:00
parent a704e43fbf
commit 1d0108ac80
Signed by: Florian Bouillon
GPG Key ID: 50BD648F12C86AB6
3 changed files with 75 additions and 68 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/dzeio/Button/Button.stories.tsx
View File

@ -25,3 +25,10 @@ WithImg.args = {
href: '/pouet',
block: true
}
export const ExternalLinkButton = (args: any) => <Component {...args}>Button</Component>
ExternalLinkButton.args = {
nomargintop: true,
href: 'https://example.com',
block: true
}

6
src/dzeio/Button/index.tsx
View File

@ -1,5 +1,5 @@
import React, { FC } from 'react'
import Link from 'next/link'
import Link from '../Link'
import { ColorType, IconProps } from '../interfaces'
import { buildClassName } from '../Util'
import Image from '../Image'
@ -57,8 +57,8 @@ export default class Button extends React.Component<Props> {
if (this.props.href) {
return (
<Link href={this.props.href} as={this.props.as}>
<a onClick={this.props.onClick} className={buildClassName([classes], [css.disabled, this.props.disabled])}>{inner}</a>
<Link linkProps={{onClick: this.props.onClick}} hideIcon noStyle href={this.props.href} className={buildClassName([classes], [css.disabled, this.props.disabled])}>
{inner}
</Link>
)
}

2
src/dzeio/Link/index.tsx
View File

@ -30,7 +30,7 @@ export default class Link extends React.Component<Props> {
public render() {
const isExternal = this.props.href.startsWith('http')
const externalProps = this.props.external ? {
const externalProps = this.props.external ?? isExternal ? {
rel: 'noreferrer nofollow',
target: '_blank'
} : {}