fix: use URL to build the URL

package-lock.json

@@ -1,12 +1,12 @@
 {
 	"name": "@tcgdex/sdk",
-	"version": "2.7.0",
+	"version": "2.6.0",
 	"lockfileVersion": 2,
 	"requires": true,
 	"packages": {
 		"": {
 			"name": "@tcgdex/sdk",
-			"version": "2.7.0",
+			"version": "2.6.0",
 			"license": "MIT",
 			"dependencies": {
 				"@cachex/memory": "^1",
@@ -10527,9 +10527,9 @@
 			}
 		},
 		"node_modules/vite": {
-			"version": "5.4.19",
-			"resolved": "https://registry.npmjs.org/vite/-/vite-5.4.19.tgz",
-			"integrity": "sha512-qO3aKv3HoQC8QKiNSTuUM1l9o/XX3+c+VTgLHbJWHZGeTPVAg2XwazI9UWzoxjIJCGCV2zU60uqMzjeLZuULqA==",
+			"version": "5.4.14",
+			"resolved": "https://registry.npmjs.org/vite/-/vite-5.4.14.tgz",
+			"integrity": "sha512-EK5cY7Q1D8JNhSaPKVK4pwBFvaTmZxEnoKXLG/U9gmdDcihQGNzFlgIvaxezFR4glP1LsuiedwMBqCXH3wZccA==",
 			"dev": true,
 			"license": "MIT",
 			"dependencies": {
@@ -18322,9 +18322,9 @@
 			}
 		},
 		"vite": {
-			"version": "5.4.19",
-			"resolved": "https://registry.npmjs.org/vite/-/vite-5.4.19.tgz",
-			"integrity": "sha512-qO3aKv3HoQC8QKiNSTuUM1l9o/XX3+c+VTgLHbJWHZGeTPVAg2XwazI9UWzoxjIJCGCV2zU60uqMzjeLZuULqA==",
+			"version": "5.4.14",
+			"resolved": "https://registry.npmjs.org/vite/-/vite-5.4.14.tgz",
+			"integrity": "sha512-EK5cY7Q1D8JNhSaPKVK4pwBFvaTmZxEnoKXLG/U9gmdDcihQGNzFlgIvaxezFR4glP1LsuiedwMBqCXH3wZccA==",
 			"dev": true,
 			"requires": {
 				"esbuild": "^0.21.3",

src/tcgdex.ts

@@ -326,19 +326,22 @@ export default class TCGdex {
 	 * format the final URL
 	 */
 	private getFullURL(
-		url: Array<string | number>,
+		path: Array<string | number>,
 		searchParams?: Array<{ key: string, value: string | number | boolean }>
 	): string {
-		// Normalize path
-		let path = url.map(this.encode).join('/')
+		// build base path
+		const url = new URL(`${this.getEndpoint()}/${this.getLang()}`)
+
+		// set url path
+		url.pathname = `${url.pathname}/${path.join('/')}`
 
 		// handle the Search Params
-		if (searchParams) {
-			path += '?' + searchParams.map((it) => `${this.encode(it.key)}=${this.encode(it.value)}`).join('&')
+		for (const param of searchParams ?? []) {
+			url.searchParams.append(param.key, param.value.toString())
 		}
 
 		// return with the endpoint and all the shit
-		return `${this.getEndpoint()}/${this.getLang()}/${path}`
+		return url.toString()
 	}
 
 	private async actualFetch<T = object>(path: string): Promise<T | undefined> {
@@ -376,26 +379,6 @@ export default class TCGdex {
 		this.cache.set(path, json, this.cacheTTL)
 		return json as T
 	}
-
-	/**
-	 * encode a string to be used in an url
-	 * @param str the string to encode to URL
-	 * @returns the encoded string
-	 */
-	private encode(str: string | number | boolean): string {
-		return encodeURI(
-			str
-				// Transform numbers to string
-				.toString()
-				// replace this special character with an escaped one
-				.replace('?', '%3F')
-				// normalize the string
-				.normalize('NFC')
-				// remove some special chars
-				// eslint-disable-next-line no-misleading-character-class
-				.replace(/["'\u0300-\u036f]/gu, '')
-		)
-	}
 }
 
 // export the old interfaces